azurerm_monitor_diagnostic_setting - retention_policy deprecated in favor of azurerm_storage_management_policy

[teowa]

fix #23250

[tombuildsstuff]

If we can fix up the documentation this should otherwise be good to go 👍

[tombuildsstuff]

this should be moved up to line 157 and also copied under line 151

[teowa]

fixed, thanks.

[stephybun]

Thanks @teowa LGTM 👍

[Panzerbjrn]

It would be really great to have some documentation to clearly show how "azurerm_storage_management_policy" should be used in place of a simple

    retention_policy {
      days    = 0 
      enabled = false
    }

block in azurerm_monitor_diagnostic_setting. Looking at azurerm_storage_management_policy doesn't really help much.

[nkol2307]

any update on this ?
is there any example how to replace this block inside azurerm_monitor_diagnostic_settings

[Flo2388]

There is also something additional missing in my opinion in the documentation:

In the documentation for the retention_policy argument you can read:

Setting this to 0 will retain the events indefinitely.

So our configuration looks like the following to disable the rule (enabled by default according to documentation) and set the storing to infinite:

  enabled_log {
    category = "logs"
    retention_policy {
      days    = 0
      enabled = false
    }
  }

What I can't find nor from the provider neither from the MS migration guide is, if the retention_policy block is deprecated, do I have to just remove the blocks to get infinite storing or do I have to implement the policy resource. And if the latter: What is the value to set for infinite logging? Just leave it to the defaults (-1), set it to 0 or what do I have to do?

From documentation for the day related settings:

(Optional) The age in days after last modification to tier blobs to archive storage. Supports blob currently at Hot or Cool tier. Must be between 0 and 99999. Defaults to -1.

Thanks for your help in advance.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.