Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource/Data Source: netapp_volume_quota_rule #23042

Merged
merged 21 commits into from
Sep 6, 2023
Merged

New Resource/Data Source: netapp_volume_quota_rule #23042

merged 21 commits into from
Sep 6, 2023

Conversation

paulomarquesc
Copy link
Contributor

This PR introduces support for the Volume Quota Rules, which allows better control over volume quotas. It also had a little refactoring where all resources based on typed schemas moved to a models package.

Unit testing results:

image

Acceptance tests for resource results:

image

Acceptance tests for data source results:

image

@paulomarquesc paulomarquesc marked this pull request as ready for review August 23, 2023 23:56
mbfrahry
mbfrahry requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @paulomarquesc, thanks for opening this PR. I've left some design change comments that should help with some of the complexity of this resource. Let me know if you have any questions

internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_data_source.go Outdated Show resolved Hide resolved
website/docs/r/netapp_volume_quota_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/netapp_volume_quota_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/d/netapp_volume_quota_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/d/netapp_volume_quota_rule.html.markdown Outdated Show resolved Hide resolved
@paulomarquesc
Copy link
Contributor Author

Hey @paulomarquesc, thanks for opening this PR. I've left some design change comments that should help with some of the complexity of this resource. Let me know if you have any questions

Hi @mbfrahry , thanks for these comments, it is all set now and ready for review.

mbfrahry
mbfrahry requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @paulomarquesc! Thanks for making those changes. I saw just a few more design things to take care of but they are pretty minor and just focus on consolidating or moving stuff around. We should be good to go after that!

internal/services/netapp/netapp_volume_quota_rule_data_source.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_data_source.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/validate/volume_id.go Outdated Show resolved Hide resolved
internal/services/netapp/validate/volume_id_test.go Outdated Show resolved Hide resolved
website/docs/d/netapp_volume_quota_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/d/netapp_volume_quota_rule.html.markdown Outdated Show resolved Hide resolved
internal/services/netapp/netapp_volume_quota_rule_resource.go Outdated Show resolved Hide resolved
mbfrahry
mbfrahry approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v3.72.0 milestone Sep 6, 2023
@mbfrahry mbfrahry changed the title New Resource/Data Source: netapp_volume_quota_rule New Resource/Data Source: netapp_volume_quota_rule Sep 6, 2023
@mbfrahry mbfrahry merged commit 230122b into hashicorp:main Sep 6, 2023
23 checks passed
@mbfrahry mbfrahry deleted the pmarques/usergroupquotas branch September 6, 2023 21:44
mbfrahry added a commit that referenced this pull request Sep 6, 2023
@mbfrahry
Update CHANGELOG.md for #23042
fafe7fe
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
dependencies documentation service/netapp size/XL
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulomarquesc @mbfrahry