Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_custom_ip_prefix - Honors customized resource manager endpoint #22812

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Aug 4, 2023

Honors customized resource manager endpoint during client initialization.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought so that we can flag this bug at PR time, but otherwise LGTM 👍

@magodo
Copy link
Collaborator Author

magodo commented Aug 4, 2023

Thank you @tombuildsstuff for the review and the suggestion! I've added the check for the usage of this simplified function in the shell script. Please take another look!

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the network_custom_ip_prefix_client_init branch from f246de5 to 9d2a983 Compare August 4, 2023 11:18
@tombuildsstuff tombuildsstuff added this to the v3.69.0 milestone Aug 4, 2023
@tombuildsstuff tombuildsstuff merged commit ce775a7 into hashicorp:main Aug 4, 2023
tombuildsstuff added a commit that referenced this pull request Aug 4, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants