Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_pim_eligible_role_assignment: fix the context deadline status check #22756

Merged
merged 1 commit into from
Aug 2, 2023
Merged

azurerm_pim_eligible_role_assignment: fix the context deadline status check #22756

merged 1 commit into from
Aug 2, 2023

Conversation

maulik13
Copy link
Contributor

@maulik13 maulik13 commented Jul 31, 2023 •
edited
Loading

AzureRM Provider Version: 3.67

Context deadline check was checking the wrong status value for error. This caused the "Delete" operation to always fail with the error message internal error: context has no deadline.

@bardholthe bardholthe mentioned this pull request Aug 1, 2023
Closed
1 task
@rcskosir rcskosir linked an issue Aug 1, 2023 that may be closed by this pull request
azurerm_pim_active_role_assignment failing when the azurerm_role_definition is provisioned at a different subscription #22730
Closed
1 task
tombuildsstuff
tombuildsstuff approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @maulik13

@tombuildsstuff tombuildsstuff added this to the v3.68.0 milestone Aug 2, 2023
@tombuildsstuff
Copy link
Contributor

The deprecated changes check above is failing because of when this was forked from main, this is fine/can be ignored.

@tombuildsstuff tombuildsstuff merged commit 5d2659c into hashicorp:main Aug 2, 2023
tombuildsstuff added a commit that referenced this pull request Aug 2, 2023
@tombuildsstuff
updating to include #22756
c3e83a7
@maulik13 maulik13 deleted the fix-pim-eligible-role-delete branch August 2, 2023 10:00
@MohnJadden
Copy link

Thank you for the fix, I was going nuts trying to figure out what was causing the error. I really appreciate all the attention that PIM is getting - we've needed the feature for a long time in TF. Good to see that issues are getting addressed in a timely fashion.

@MohnJadden MohnJadden mentioned this pull request Aug 3, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/authorization size/XS waiting-response
Projects
None yet
Milestone
v3.68.0
3 participants
@maulik13 @tombuildsstuff @MohnJadden