Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machinelearningservice: update sdk to 2023-04-01 #22729

Merged
merged 6 commits into from
Aug 1, 2023
Merged

machinelearningservice: update sdk to 2023-04-01 #22729

merged 6 commits into from
Aug 1, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Jul 28, 2023 •
edited
Loading

to add new resource MachineLearningServices/registries which need a newer api version. and update client.Client to use the meta client.

image

@wuxu92 wuxu92 marked this pull request as draft July 28, 2023 07:05
@wuxu92 wuxu92 marked this pull request as ready for review July 28, 2023 13:27
tombuildsstuff
tombuildsstuff suggested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @wuxu92

Since we're only using 3 of the 30 SDK clients, switching to use the Meta Client and importing all 30 SDK's seems overkill - are you intending to implement additional functionality using those other SDKs anytime soon, if not we revert this to using the SDK clients directly (since it'd mean we're not importing unused dependencies).

Thanks!

vendor/modules.txt Outdated Show resolved Hide resolved
@wuxu92 wuxu92 changed the title machinelearningservice: update sdk to 2023-04-01 and use MetaClient machinelearningservice: update sdk to 2023-04-01 Aug 1, 2023
tombuildsstuff
tombuildsstuff approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing that change @wuxu92

@tombuildsstuff tombuildsstuff merged commit c84ff11 into hashicorp:main Aug 1, 2023
@tombuildsstuff tombuildsstuff added this to the v3.68.0 milestone Aug 1, 2023
tombuildsstuff added a commit that referenced this pull request Aug 1, 2023
@tombuildsstuff
updating to include #22729
62cfa73
@wuxu92 wuxu92 deleted the mlsdk/20230401 branch August 1, 2023 13:07
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/databricks service/machine-learning size/XL
Projects
None yet
Milestone
v3.68.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wuxu92 @tombuildsstuff