Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cosmosdb_account - fixes regression to default_identity_type being switched to FirstPartyIdentity on update #22609

Merged
merged 2 commits into from
Jul 20, 2023
Merged

azurerm_cosmosdb_account - fixes regression to default_identity_type being switched to FirstPartyIdentity on update #22609

merged 2 commits into from
Jul 20, 2023

Conversation

WodansSon
Copy link
Collaborator

(fixes #22466)

@WodansSon WodansSon requested a review from katbyte July 19, 2023 23:59
@WodansSon
Copy link
Collaborator Author

image

manicminer
manicminer approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WodansSon, LGTM 👍

internal/services/cosmos/cosmosdb_account_resource_test.go Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v3.66.0 milestone Jul 20, 2023
@WodansSon WodansSon merged commit 0501e75 into main Jul 20, 2023
@WodansSon WodansSon deleted the b_cosmos_firstpartyswitch branch July 20, 2023 21:56
WodansSon added a commit that referenced this pull request Jul 20, 2023
@WodansSon
updated to include #22609
842e13b
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
bug service/cosmosdb size/M
Projects
None yet
Milestone
v3.66.0
2 participants
@WodansSon @manicminer