Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies - swap azurerm_bastion_host and azurerm_network_connection_monitor to hashicorp/go-azure-sdk #22425

Merged
merged 2 commits into from
Jul 13, 2023
Merged

dependencies - swap azurerm_bastion_host and azurerm_network_connection_monitor to hashicorp/go-azure-sdk #22425

merged 2 commits into from
Jul 13, 2023

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Jul 8, 2023 •
edited
Loading

image

TestAccNetworkWatcher is a combined test and the same tests failing in main are failing here so we should be ok to merge

@tombuildsstuff tombuildsstuff mentioned this pull request Jul 10, 2023
Closed
katbyte
katbyte approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ♻️

@mbfrahry mbfrahry added this to the v3.66.0 milestone Jul 13, 2023
@mbfrahry mbfrahry merged commit ba851d6 into main Jul 13, 2023
@mbfrahry mbfrahry deleted the swap-b-network-sdk branch July 13, 2023 23:13
mbfrahry added a commit that referenced this pull request Jul 13, 2023
@mbfrahry
Update CHANGELOG.md for #22425
44b51dd
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees

@hc-github-team-tf-azure hc-github-team-tf-azure

Labels
dependencies service/network size/XL
Projects
None yet
Milestone
v3.66.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mbfrahry @katbyte @hc-github-team-tf-azure