Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch: updating to use API Version 2023-05-01 #22412

Merged
merged 3 commits into from
Jul 12, 2023
Merged

batch: updating to use API Version 2023-05-01 #22412

merged 3 commits into from
Jul 12, 2023

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

@tombuildsstuff tombuildsstuff requested a review from a team July 7, 2023 14:20
@tombuildsstuff tombuildsstuff added this to the v3.65.0 milestone Jul 7, 2023
@tombuildsstuff tombuildsstuff mentioned this pull request Jul 7, 2023
Closed
@tombuildsstuff
Copy link
Contributor Author

Dependent on hashicorp/pandora#2736

@tombuildsstuff tombuildsstuff force-pushed the f/upgrading-batch-to-2023-05-01 branch from 293cec2 to 4f7c2a7 Compare July 11, 2023 14:52
mbfrahry
mbfrahry approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff mentioned this pull request Jul 11, 2023
Merged
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2023-07-12 at 09 01 52

@tombuildsstuff tombuildsstuff merged commit f1753a5 into main Jul 12, 2023
@tombuildsstuff tombuildsstuff deleted the f/upgrading-batch-to-2023-05-01 branch July 12, 2023 07:02
tombuildsstuff added a commit that referenced this pull request Jul 12, 2023
@tombuildsstuff
updating to include #22412
dd0982f
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
dependencies service/batch size/M
Projects
None yet
Milestone
v3.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry