Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automat_dsc_configuration: update sdk to 2022-08-08 #22403

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Jul 7, 2023

based on #22404

update to the new base-layered sdk wil fix below acc tests (because of old sdk cannot process literal string reponse body):

TestAccAutomationDscConfiguration_basic
TestAccAutomationDscConfiguration_complete
TestAccAutomationDscConfiguration_requiresImport
TestAccAutomationDscNodeConfiguration_basic
TestAccAutomationDscNodeConfiguration_requiresImport

Test Result:

--- PASS: TestAccAutomationDscNodeConfiguration_basic (130.93s)
--- PASS: TestAccAutomationDscNodeConfiguration_requiresImport (207.52s)
--- PASS: TestAccAutomationDscConfiguration_basic (185.03s)
--- PASS: TestAccAutomationDscConfiguration_requiresImport (197.80s)
--- PASS: TestAccAutomationDscConfiguration_complete (191.34s)
PASS

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @wuxu92

Thanks for this PR - taking a look through here it appears that we're going to want to split the changes in this PR though:

  • hashicorp/go-azure-sdk tends to be updated regularly, as such can we split the SDK upgrade out of this PR?
  • We'll need to remove the new fields which aren't returned from the API - and open an API tracking that, a field needs to be returned from the API for us to support it in Terraform, else this breaks import support - so we'll need that fixed before we can re-introduce those.

However if we can make those changes then this should otherwise be good to go 👍

Thanks!

internal/clients/client.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
website/docs/r/automation_dsc_configuration.html.markdown Outdated Show resolved Hide resolved
@wuxu92 wuxu92 changed the title automat_dsc_configuration: update sdk to 2022-08-08 and support log_progress, hash, source_version automat_dsc_configuration: update sdk to 2022-08-08 Jul 7, 2023
@wuxu92
Copy link
Contributor Author

wuxu92 commented Jul 7, 2023

@tombuildsstuff thanks! the go-azure-sdk PR in #22404 . This PR is to only update the dscconfiguration to 2022-08-08, new fields logic removed and the API issue tracked by Azure/azure-rest-api-specs#24728

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around adding back in the Import check for the Complete test (which I'm going to push a commit for) but this otherwise LGTM - thanks for making those changes @wuxu92

@tombuildsstuff
Copy link
Contributor

(rebased this atop of main to remove the vendor changes made outside of this PR too)

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2023-07-07 at 15 22 03

@tombuildsstuff tombuildsstuff added this to the v3.65.0 milestone Jul 7, 2023
@tombuildsstuff tombuildsstuff merged commit d185afa into hashicorp:main Jul 7, 2023
tombuildsstuff added a commit that referenced this pull request Jul 7, 2023
@wuxu92 wuxu92 deleted the auto/config branch July 9, 2023 00:47
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants