Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kermit version to v0.20230703.1101016 #22390

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Update kermit version to v0.20230703.1101016 #22390

merged 3 commits into from
Jul 7, 2023

Conversation

KenSpur
Copy link
Contributor

@KenSpur KenSpur commented Jul 6, 2023 •
edited
Loading

issue: #22338
pr: #22382

@KenSpur KenSpur mentioned this pull request Jul 6, 2023
Closed
11 tasks
@KenSpur
Copy link
Contributor Author

KenSpur commented Jul 6, 2023

@tombuildsstuff should be ok now

@KenSpur
Copy link
Contributor Author

KenSpur commented Jul 7, 2023

@tombuildsstuff running go mod vendor seems to remove the "github.com/tombuildsstuff/kermit/sdk/iotcentral/2022-10-31-preview/iotcentral" sdk since there is no dependency yet. Should i leave it out or create a small dependency?

@tombuildsstuff
Copy link
Contributor

@KenSpur leaving the dependency out of this PR would be fine - we can vendor that specifically within #22382 since it's tied to that PR (and won't have merge conflicts since it's tracked in that PR) - but if you can fix that up this should otherwise be good to merge, thanks 👍

@github-actions github-actions bot added size/XS and removed size/XL labels Jul 7, 2023
@KenSpur KenSpur changed the title Update kermit version to v0.20230703.1101016 & pull in kermit/sdk/iotcentral/2022-10-31-preview/iotcentral Update kermit version to v0.20230703.1101016 Jul 7, 2023
tombuildsstuff
tombuildsstuff approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @KenSpur

@tombuildsstuff tombuildsstuff merged commit 8e658ba into hashicorp:main Jul 7, 2023
@tombuildsstuff tombuildsstuff added this to the v3.65.0 milestone Jul 7, 2023
tombuildsstuff added a commit that referenced this pull request Jul 7, 2023
@tombuildsstuff
updating to include #22390
a7f66c5
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies size/XS
Projects
None yet
Milestone
v3.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KenSpur @tombuildsstuff