Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_dns_resolver_forwarding_rule_resource - make domain_name force new #22375

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

maxxieb
Copy link
Contributor

@maxxieb maxxieb commented Jul 5, 2023

when trying to perform update in place azure throws an error:

forwardingrules.ForwardingRulesClient#CreateOrUpdate: Failure responding to request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=409 Code="Conflict" Message="Exception of type 'Microsoft.Azure.Networking.Dns.ManagedResolver.Frontend.Contracts.Exceptions.Service.FrontendConflictServiceException' was thrown." Target="" Details=[{}] InnerError={}

Probably because it's impossible to do such update through azure portal as well.

when trying to perform update in place azure throws an error:

```
forwardingrules.ForwardingRulesClient#CreateOrUpdate: Failure responding to request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=409 Code="Conflict" Message="Exception of type 'Microsoft.Azure.Networking.Dns.ManagedResolver.Frontend.Contracts.Exceptions.Service.FrontendConflictServiceException' was thrown." Target="" Details=[{}] InnerError={}
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbrydak! This looks good but the documentation for domain_name needs to be changed as well to say that Changing this forces a new Private DNS Resolver Forwarding Rule to be created.

@maxxieb
Copy link
Contributor Author

maxxieb commented Jul 6, 2023

@mbfrahry thanks for the reminder, I've updated the docs.

@maxxieb maxxieb requested a review from mbfrahry July 6, 2023 13:05
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mbrydak ! LGTM ⛈️

@katbyte katbyte changed the title Update private_dns_resolver_forwarding_rule_resource.go azurerm_private_dns_resolver_forwarding_rule_resource - domain_name is no force new Jul 6, 2023
@katbyte katbyte changed the title azurerm_private_dns_resolver_forwarding_rule_resource - domain_name is no force new azurerm_private_dns_resolver_forwarding_rule_resource - make domain_name force new Jul 6, 2023
@katbyte katbyte merged commit db97ba1 into hashicorp:main Jul 6, 2023
@github-actions github-actions bot added this to the v3.64.0 milestone Jul 6, 2023
katbyte added a commit that referenced this pull request Jul 6, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants