Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_site_recovery_replication_recovery_plan: keep the order of recovery_group #22348

Merged
merged 11 commits into from
Jul 20, 2023
Merged

azurerm_site_recovery_replication_recovery_plan: keep the order of recovery_group #22348

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3411bab
`azurerm_site_recovery_replication_recovery_plan`: keep the order of …
ziyeqf Jul 3, 2023
59e4679
update testcase
ziyeqf Jul 3, 2023
50bd332
update per comments
ziyeqf Jul 4, 2023
a5269ff
update code
ziyeqf Jul 4, 2023
14772ce
golint
ziyeqf Jul 4, 2023
aa0b8f1
update testcase
ziyeqf Jul 4, 2023
d890c13
limit `shutdown_recovery_group` and `failover_recovery_group` to 1
ziyeqf Jul 6, 2023
40b5a24
update code
ziyeqf Jul 7, 2023
caebbf8
golint
ziyeqf Jul 10, 2023
f82f6df
lint
ziyeqf Jul 20, 2023
964290a
Document wording tweaks
manicminer Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 112 additions & 3 deletions internal/services/recoveryservices/site_recovery_replication_recovery_plan_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"time"

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-helpers/lang/response"
"github.com/hashicorp/go-azure-sdk/resource-manager/recoveryservicessiterecovery/2022-10-01/replicationrecoveryplans"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
Expand All @@ -15,6 +16,40 @@ import (

type SiteRecoveryReplicationRecoveryPlanDataSource struct{}

type SiteRecoveryReplicationRecoveryPlanDataSourceModel struct {
Name string `tfschema:"name"`
RecoveryGroup []RecoveryGroupDataSourceModel `tfschema:"recovery_group"`
RecoveryVaultId string `tfschema:"recovery_vault_id"`
SourceRecoveryFabricId string `tfschema:"source_recovery_fabric_id"`
TargetRecoveryFabricId string `tfschema:"target_recovery_fabric_id"`
A2ASettings []ReplicationRecoveryPlanA2ASpecificInputDataSourceModel `tfschema:"azure_to_azure_settings"`
}

type RecoveryGroupDataSourceModel struct {
GroupType string `tfschema:"type"`
PostAction []ActionDataSourceModel `tfschema:"post_action"`
PreAction []ActionDataSourceModel `tfschema:"pre_action"`
ReplicatedProtectedItems []string `tfschema:"replicated_protected_items"`
}

type ActionDataSourceModel struct {
ActionDetailType string `tfschema:"type"`
FabricLocation string `tfschema:"fabric_location"`
FailOverDirections []string `tfschema:"fail_over_directions"`
FailOverTypes []string `tfschema:"fail_over_types"`
ManualActionInstruction string `tfschema:"manual_action_instruction"`
Name string `tfschema:"name"`
RunbookId string `tfschema:"runbook_id"`
ScriptPath string `tfschema:"script_path"`
}

type ReplicationRecoveryPlanA2ASpecificInputDataSourceModel struct {
PrimaryZone string `tfschema:"primary_zone"`
RecoveryZone string `tfschema:"recovery_zone"`
PrimaryEdgeZone string `tfschema:"primary_edge_zone"`
RecoveryEdgeZone string `tfschema:"recovery_edge_zone"`
}

var _ sdk.DataSource = SiteRecoveryReplicationRecoveryPlanDataSource{}

func (r SiteRecoveryReplicationRecoveryPlanDataSource) ResourceType() string {
Expand Down Expand Up @@ -60,7 +95,7 @@ func (r SiteRecoveryReplicationRecoveryPlanDataSource) Read() sdk.ResourceFunc {
return fmt.Errorf("making Read request on site recovery replication plan %s : model is nil", id.String())
}

state := SiteRecoveryReplicationRecoveryPlanModel{
state := SiteRecoveryReplicationRecoveryPlanDataSourceModel{
Name: id.ReplicationRecoveryPlanName,
RecoveryVaultId: vaultId.ID(),
}
Expand All @@ -74,19 +109,77 @@ func (r SiteRecoveryReplicationRecoveryPlanDataSource) Read() sdk.ResourceFunc {
}

if group := prop.Groups; group != nil {
state.RecoveryGroup = flattenRecoveryGroups(*group)
state.RecoveryGroup = flattenDataSourceRecoveryGroups(*group)
}

if details := prop.ProviderSpecificDetails; details != nil && len(*details) > 0 {
state.A2ASettings = flattenRecoveryPlanProviderSpecficInput(details)
state.A2ASettings = flattenDataSourceRecoveryPlanProviderSpecficInput(details)
}
}

metadata.SetID(id)
return metadata.Encode(&state)
},
}
}

func flattenDataSourceRecoveryGroups(input []replicationrecoveryplans.RecoveryPlanGroup) []RecoveryGroupDataSourceModel {
output := make([]RecoveryGroupDataSourceModel, 0)
for _, groupItem := range input {
recoveryGroupOutput := RecoveryGroupDataSourceModel{}
recoveryGroupOutput.GroupType = string(groupItem.GroupType)
if groupItem.ReplicationProtectedItems != nil {
recoveryGroupOutput.ReplicatedProtectedItems = flattenRecoveryPlanProtectedItems(groupItem.ReplicationProtectedItems)
}
if groupItem.StartGroupActions != nil {
recoveryGroupOutput.PreAction = flattenDataSourceRecoveryPlanActions(groupItem.StartGroupActions)
}
if groupItem.EndGroupActions != nil {
recoveryGroupOutput.PostAction = flattenDataSourceRecoveryPlanActions(groupItem.EndGroupActions)
}
output = append(output, recoveryGroupOutput)
}
return output
}

func flattenDataSourceRecoveryPlanActions(input *[]replicationrecoveryplans.RecoveryPlanAction) []ActionDataSourceModel {
actionOutputs := make([]ActionDataSourceModel, 0)
for _, action := range *input {
actionOutput := ActionDataSourceModel{
Name: action.ActionName,
}
switch detail := action.CustomDetails.(type) {
case replicationrecoveryplans.RecoveryPlanAutomationRunbookActionDetails:
actionOutput.ActionDetailType = "AutomationRunbookActionDetails"
actionOutput.FabricLocation = string(detail.FabricLocation)
if detail.RunbookId != nil {
actionOutput.RunbookId = *detail.RunbookId
}
case replicationrecoveryplans.RecoveryPlanManualActionDetails:
actionOutput.ActionDetailType = "ManualActionDetails"
if detail.Description != nil {
actionOutput.ManualActionInstruction = *detail.Description
}
case replicationrecoveryplans.RecoveryPlanScriptActionDetails:
actionOutput.ActionDetailType = "ScriptActionDetails"
actionOutput.ScriptPath = detail.Path
actionOutput.FabricLocation = string(detail.FabricLocation)
}

failoverDirections := make([]string, 0)
for _, failoverDirection := range action.FailoverDirections {
failoverDirections = append(failoverDirections, string(failoverDirection))
}

failoverTypes := make([]string, 0)
for _, failoverType := range action.FailoverTypes {
failoverTypes = append(failoverTypes, string(failoverType))
}
actionOutput.FailOverDirections = failoverDirections
actionOutput.FailOverTypes = failoverTypes
actionOutputs = append(actionOutputs, actionOutput)
}
return actionOutputs
}

func (r SiteRecoveryReplicationRecoveryPlanDataSource) Arguments() map[string]*pluginsdk.Schema {
Expand All @@ -105,6 +198,22 @@ func (r SiteRecoveryReplicationRecoveryPlanDataSource) Arguments() map[string]*p
}
}

func flattenDataSourceRecoveryPlanProviderSpecficInput(input *[]replicationrecoveryplans.RecoveryPlanProviderSpecificDetails) []ReplicationRecoveryPlanA2ASpecificInputDataSourceModel {
output := make([]ReplicationRecoveryPlanA2ASpecificInputDataSourceModel, 0)
for _, providerSpecificInput := range *input {
if a2aInput, ok := providerSpecificInput.(replicationrecoveryplans.RecoveryPlanA2ADetails); ok {
o := ReplicationRecoveryPlanA2ASpecificInputDataSourceModel{
PrimaryZone: pointer.From(a2aInput.PrimaryZone),
RecoveryZone: pointer.From(a2aInput.RecoveryZone),
PrimaryEdgeZone: flattenEdgeZone(a2aInput.PrimaryExtendedLocation),
RecoveryEdgeZone: flattenEdgeZone(a2aInput.RecoveryExtendedLocation),
}
output = append(output, o)
}
}
return output
}

func (r SiteRecoveryReplicationRecoveryPlanDataSource) Attributes() map[string]*pluginsdk.Schema {
return map[string]*pluginsdk.Schema{
"source_recovery_fabric_id": {
Expand Down
6 changes: 0 additions & 6 deletions ...nal/services/recoveryservices/site_recovery_replication_recovery_plan_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ func TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic(t *testing.T) {
check.That(data.ResourceName).Key("recovery_vault_id").Exists(),
check.That(data.ResourceName).Key("source_recovery_fabric_id").Exists(),
check.That(data.ResourceName).Key("target_recovery_fabric_id").Exists(),
check.That(data.ResourceName).Key("recovery_group.0.type").HasValue("Boot"),
check.That(data.ResourceName).Key("recovery_group.1.type").HasValue("Failover"),
check.That(data.ResourceName).Key("recovery_group.2.type").HasValue("Shutdown"),
),
},
})
Expand All @@ -42,9 +39,6 @@ func TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_withZones(t *testing.T
check.That(data.ResourceName).Key("recovery_vault_id").Exists(),
check.That(data.ResourceName).Key("source_recovery_fabric_id").Exists(),
check.That(data.ResourceName).Key("target_recovery_fabric_id").Exists(),
check.That(data.ResourceName).Key("recovery_group.0.type").HasValue("Boot"),
check.That(data.ResourceName).Key("recovery_group.1.type").HasValue("Failover"),
check.That(data.ResourceName).Key("recovery_group.2.type").HasValue("Shutdown"),
check.That(data.ResourceName).Key("azure_to_azure_settings.0.primary_zone").HasValue("1"),
check.That(data.ResourceName).Key("azure_to_azure_settings.0.recovery_zone").HasValue("2"),
),
Expand Down
Loading