New Resource: azurerm_kusto_cosmosdb_data_connection

[liuwuliuyun]

New Resource: azurerm_kusto_cosmosdb_data_connection

Swagger

• https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2022-12-29/kusto.json

New Properties:

• cluster_name - (Required) The name of the Kusto cluster. Changing this forces a new Data Explorer to be created.

• cosmosdb_account_id - (Required) The resource ID of the Cosmos DB account used to create the data connection. Changing this forces a new Data Explorer to be created.

• cosmosdb_container - (Required) The name of an existing container in the Cosmos DB database. Changing this forces a new Data Explorer to be created.

• cosmosdb_database - (Required) The name of an existing database in the Cosmos DB account. Changing this forces a new Data Explorer to be created.

• database_name - (Required) The name of the database in the Kusto cluster. Changing this forces a new Data Explorer to be created.

• location - (Required) The Azure Region where the Data Explorer should exist. Changing this forces a new Data Explorer to be created.

• managed_identity_id - (Required) The resource ID of a managed system or user-assigned identity. The identity is used to authenticate with Cosmos DB. Changing this forces a new Data Explorer to be created.

• name - (Required) The name of the data connection. Changing this forces a new Data Explorer to be created.

• resource_group_name - (Required) The name of the Resource Group where the Data Explorer should exist. Changing this forces a new Data Explorer to be created.

• table_name - (Required) The case-sensitive name of the existing target table in your cluster. Retrieved data is ingested into this table. Changing this forces a new Data Explorer to be created.

• mapping_rule_name - (Optional) The name of an existing mapping rule to use when ingesting the retrieved data.

• retrieval_start_date - (Optional) If defined, the data connection retrieves Cosmos DB documents created or updated after the specified retrieval start date.

[liuwuliuyun]

TF_ACC=1 go test -parallel 10 -v ./internal/services/kusto -run=TestAccKustoCosmosDBDataConnection_ -timeout '720m' -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
========================== Starting Command Output ===========================
/usr/bin/bash /mnt/vss/_work/_temp/dd466eea-de42-4276-9aa2-06ea826ebc3d.sh
=== RUN TestAccKustoCosmosDBDataConnection_basic
=== PAUSE TestAccKustoCosmosDBDataConnection_basic
=== RUN TestAccKustoCosmosDBDataConnection_complete
=== PAUSE TestAccKustoCosmosDBDataConnection_complete
=== RUN TestAccKustoCosmosDBDataConnection_requiresImport
=== PAUSE TestAccKustoCosmosDBDataConnection_requiresImport
=== CONT TestAccKustoCosmosDBDataConnection_basic
=== CONT TestAccKustoCosmosDBDataConnection_requiresImport
=== CONT TestAccKustoCosmosDBDataConnection_complete
--- PASS: TestAccKustoCosmosDBDataConnection_basic (1509.48s)
--- PASS: TestAccKustoCosmosDBDataConnection_requiresImport (1534.44s)
--- PASS: TestAccKustoCosmosDBDataConnection_complete (1588.97s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto 1589.008s
Finishing: Run test in parallel

[stephybun]

Thanks for this PR @liuwuliuyun.

I've left some comments in-line which need to be addressed. Once that's done I can proceed with my review.

Thanks!

[stephybun]

If this is the managed identity from the cosmosdb resource can we specify that in the name?

Suggested change

	"managed_identity_id": {
	"cosmosdb_managed_identity_id": {

[liuwuliuyun]

not exactly, this identity id could be user assigned identity id or a system assigned identity id (resource id) in some cases.

[liuwuliuyun]

You could see the similar managed_identity_id in other kusto data connection resources

[liuwuliuyun]

Finshied suggested change and here is the testing evidence.

TF_ACC=1 go test -parallel 10 -v ./internal/services/kusto -run=TestAccKustoCosmosDBDataConnection_ -timeout '720m' -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
========================== Starting Command Output ===========================
/usr/bin/bash /mnt/vss/_work/_temp/3d9e695c-51fb-4894-851f-7a938c6cbdbd.sh
=== RUN   TestAccKustoCosmosDBDataConnection_basic
=== PAUSE TestAccKustoCosmosDBDataConnection_basic
=== RUN   TestAccKustoCosmosDBDataConnection_complete
=== PAUSE TestAccKustoCosmosDBDataConnection_complete
=== RUN   TestAccKustoCosmosDBDataConnection_requiresImport
=== PAUSE TestAccKustoCosmosDBDataConnection_requiresImport
=== CONT  TestAccKustoCosmosDBDataConnection_basic
=== CONT  TestAccKustoCosmosDBDataConnection_requiresImport
=== CONT  TestAccKustoCosmosDBDataConnection_complete
--- PASS: TestAccKustoCosmosDBDataConnection_complete (1568.89s)
--- PASS: TestAccKustoCosmosDBDataConnection_requiresImport (1596.37s)
--- PASS: TestAccKustoCosmosDBDataConnection_basic (1883.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto	1883.419s
Finishing: Run test in parallel

[liuwuliuyun]

Generating script.
Script contents:
TF_ACC=1 go test -parallel 10 -v ./internal/services/kusto -run=TestAccKustoCosmosDBDataConnection_ -timeout '720m' -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
========================== Starting Command Output ===========================
/usr/bin/bash /mnt/vss/_work/_temp/efaa4bde-7613-4c0b-80cc-9f1bc6bb68bc.sh
=== RUN   TestAccKustoCosmosDBDataConnection_basic
=== PAUSE TestAccKustoCosmosDBDataConnection_basic
=== RUN   TestAccKustoCosmosDBDataConnection_complete
=== PAUSE TestAccKustoCosmosDBDataConnection_complete
=== RUN   TestAccKustoCosmosDBDataConnection_requiresImport
=== PAUSE TestAccKustoCosmosDBDataConnection_requiresImport
=== CONT  TestAccKustoCosmosDBDataConnection_basic
=== CONT  TestAccKustoCosmosDBDataConnection_requiresImport
=== CONT  TestAccKustoCosmosDBDataConnection_complete
--- PASS: TestAccKustoCosmosDBDataConnection_complete (1535.57s)
--- PASS: TestAccKustoCosmosDBDataConnection_basic (1550.99s)
--- PASS: TestAccKustoCosmosDBDataConnection_requiresImport (1587.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto	1587.114s
Finishing: Run test in parallel

[stephybun]

Thanks @liuwuliuyun LGTM 💭

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.