-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to set ManagedBy field. #22012
Conversation
hey @rna-afk Thanks for this PR. Last time we looked into this, unfortunately the However in the proposed changes this is being exposed as a read-only field (since it's only being set from the API Response), so I'm curious as to the use-case for this field - are you looking to use the value from this field in another resource, or are you looking to manage this field? Thanks! |
We are just looking to use this field for some automated system that we have running in the background that just checks the field and installs a few RBAC resources into the resource group if the right value is set. The almost immutable nature of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @rna-afk. Looking into this it appears this field can be set.
In addition to the comments left below we need to add an additional acceptance test for this property and also to update the documentation. Once those points have been resolved we can get this merged. Thanks!
Thanks for the suggestions @stephybun . I fixed them and added unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rna-afk, one more comment and the docs still need to be updated.
Thanks @stephybun, added docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @rna-afk
I've left a few comments below if you can take a look, then we can get this tested.
Thanks!
Adding the option to set the ManagedBy field to the `azure_resource_group` resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @rna-afk LGTM 🌻
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adding the option to set the ManagedBy field to
the
azure_resource_group
resource.