security.watchitems: updating to use hashicorp/go-azure-sdk
#21944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
service/sentinel
service/signalr
size/XL
waiting-response
labels
mbfrahry
requested changes
May 26, 2023
There was a problem hiding this comment.
This looks good sans one test failure which is just a quick fix around id parsing.
=== CONT TestAccWatchlistItem_update
testcase.go:110: Step 3/6 error: Error running apply: exit status 1
Error: parsing "/subscriptions/*******/resourceGroups/acctestRG-sentinel-230526221130409583/providers/Microsoft.OperationalInsights/workspaces/acctest-workspace-230526221130409583/providers/Microsoft.SecurityInsights/watchlists/accTestWL-230526221130409583": parsing the WatchlistItem ID: the number of segments didn't match
Expected a WatchlistItem ID that matched (containing 14 segments):
> /subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/example-resource-group/providers/Microsoft.OperationalInsights/workspaces/workspaceValue/providers/Microsoft.SecurityInsights/watchlists/watchlistAliasValue/watchlistItems/watchlistItemIdValue
However this value was provided (which was parsed into 0 segments):
> /subscriptions/*******/resourceGroups/acctestRG-sentinel-230526221130409583/providers/Microsoft.OperationalInsights/workspaces/acctest-workspace-230526221130409583/providers/Microsoft.SecurityInsights/watchlists/accTestWL-230526221130409583
| @@ -184,29 +165,30 @@ func (r WatchlistItemResource) Update() sdk.ResourceFunc { | |||
| return fmt.Errorf("decoding %+v", err) | |||
| } | |||
|
|
|||
| watchlistId, err := parse.WatchlistID(model.WatchlistID) | |||
| watchlistId, err := watchlistitems.ParseWatchlistItemID(model.WatchlistID) | |||
There was a problem hiding this comment.
This is causing a test failure. I think it wants to be:
Suggested change
| watchlistId, err := watchlistitems.ParseWatchlistItemID(model.WatchlistID) | |
| watchlistId, err := watchlistitems.ParseWatchlist(model.WatchlistID) |
mbfrahry
changed the title
security.watchitems: updating to use hashicorp/go-azure-sdk
mbfrahry
added a commit
that referenced
this pull request
May 31, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.