-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Datasource: azurerm_arc_machine
#21796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @liuwuliuyun
Thanks for this PR.
Left some comments inline, but if we can fix those up then this should otherwise be good to go 👍
Thanks!
internal/services/hybridcompute/hybrid_compute_machine_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/hybrid_compute_machine_data_source.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌵
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
New Datasource:
azurerm_arc_machine
Context
#21027
As agreed in above context, this is the first step to replace datasource
azurerm_hybrid_compute_machine
with new datasourceazurerm_arc_machine
.Any future update will be coded in the new one and datasource
azurerm_hybrid_compute_machine
will be deprecated in 4.0 and later version.Welcome any suggestions!
Testing evidence
GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___2TestAccArcMachine_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/hybridcompute #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___2TestAccArcMachine_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccArcMachine_basic\E$ #gosetup
=== RUN TestAccArcMachine_basic
=== PAUSE TestAccArcMachine_basic
=== CONT TestAccArcMachine_basic
--- PASS: TestAccArcMachine_basic (442.44s)
PASS
Process finished with the exit code 0
GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___go_test_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/hybridcompute #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___go_test_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe -test.v -test.paniconexit0 #gosetup
=== RUN TestAccArcMachine_basic
=== PAUSE TestAccArcMachine_basic
=== CONT TestAccArcMachine_basic
--- PASS: TestAccArcMachine_basic (443.74s)
=== RUN TestAccHybridComputeMachine_basic
=== PAUSE TestAccHybridComputeMachine_basic
=== CONT TestAccHybridComputeMachine_basic
--- PASS: TestAccHybridComputeMachine_basic (410.55s)
PASS
Process finished with the exit code 0