-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for setting client ID / secret through files #21764
Allow for setting client ID / secret through files #21764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mpminardi, happy to add this functionality. This change mostly looks good, I've tweaked & renamed a few things for consistency. I think we're going to have to run the tests using t.SetEnv()
serially as env vars are process-wide, I'll add this similarly to how we do the same with other acceptance tests.
Sounds good, thank you for the cleanup and fixing the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mpminardi we and @manicminer - This LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adds the ability to specify a path to the client ID and client secret in place of supplying their values directly in the provider.