Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting client ID / secret through files #21764

Conversation

mpminardi
Copy link
Contributor

Adds the ability to specify a path to the client ID and client secret in place of supplying their values directly in the provider.

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpminardi, happy to add this functionality. This change mostly looks good, I've tweaked & renamed a few things for consistency. I think we're going to have to run the tests using t.SetEnv() serially as env vars are process-wide, I'll add this similarly to how we do the same with other acceptance tests.

internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider_test.go Outdated Show resolved Hide resolved
internal/provider/provider_test.go Outdated Show resolved Hide resolved
internal/provider/provider_test.go Outdated Show resolved Hide resolved
internal/provider/provider_test.go Outdated Show resolved Hide resolved
internal/provider/provider_test.go Outdated Show resolved Hide resolved
@manicminer manicminer requested a review from tombuildsstuff May 16, 2023 22:06
@mpminardi
Copy link
Contributor Author

Thanks @mpminardi, happy to add this functionality. This change mostly looks good, I've tweaked & renamed a few things for consistency. I think we're going to have to run the tests using t.SetEnv() serially as env vars are process-wide, I'll add this similarly to how we do the same with other acceptance tests.

Sounds good, thank you for the cleanup and fixing the tests!

@manicminer manicminer added this to the v3.60.0 milestone Jun 6, 2023
@manicminer manicminer requested a review from a team June 7, 2023 13:41
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpminardi we and @manicminer - This LGTM 👍

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants