-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the error messages when Resource ID parsing fails #21725
Conversation
This PR needs the upstream PR merged/vendored so that |
946b453
to
ea42498
Compare
The Resource ID Parsers contain enough information so we don't need to double-wrap this
…-helpers` and `v0.20230510.1131358` of `github.com/hashicorp/go-azure-sdk`
6a8f199
to
a6e1d02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tombuildsstuff - One minor comment to address a small grammatical issue, but otherwise LGTM 👍
This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Dependent on hashicorp/go-azure-helpers#155
This PR improves the error messages from the provider when a Resource ID doesn't parse correctly, these screenshots from hashicorp/go-azure-helpers#155 show some of the changes (the
parsing Resource ID %q
is no longer present, as of this PR):The latest changes improve things quite considerably when the incorrect Resource ID is specified:
And also when the casing of a given segment is incorrect:
When an extra segment is specified, this is now output as:
Changelog: