Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Datasource: azurerm_virtual_hub_connection #21681

Merged
merged 10 commits into from
May 17, 2023
Merged

New Datasource: azurerm_virtual_hub_connection #21681

merged 10 commits into from
May 17, 2023

Conversation

TechyMatt
Copy link
Contributor

No description provided.

TechyMatt and others added 6 commits May 5, 2023 10:58
tombuildsstuff
tombuildsstuff suggested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments but this otherwise LGTM - thanks for this @TechyMatt

internal/services/network/virtual_hub_connection_data_source.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_connection_data_source.go Outdated Show resolved Hide resolved
website/docs/d/virtual_hub_connection.html.markdown Outdated Show resolved Hide resolved
website/docs/d/virtual_hub_connection.html.markdown Outdated Show resolved Hide resolved
@TechyMatt
Copy link
Contributor Author

Thanks @tombuildsstuff changes made per comments.

@TechyMatt TechyMatt requested a review from tombuildsstuff May 17, 2023 12:16
katbyte
katbyte approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TechyMatt - aside from one minor comment LGTM 🔧

website/docs/d/virtual_hub_connection.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 114a69b into hashicorp:main May 17, 2023
@github-actions github-actions bot added this to the v3.57.0 milestone May 17, 2023
katbyte added a commit that referenced this pull request May 17, 2023
@katbyte
Update CHANGELOG.md #21681
d49ffbe
@github-actions
Copy link

This functionality has been released in v3.57.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation service/network size/L
Projects
None yet
Milestone
v3.57.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TechyMatt @tombuildsstuff @katbyte