azurerm_site_recovery_replication_recovery_plan: support azure_to_azure_settings

[ziyeqf]

fix #21584

test

tftest recoveryservices TestAccSiteRecoveryReplicationRecoveryPlan          
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_withZones
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_withZones
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withZones
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions (2968.79s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_basic (3000.41s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions (3096.27s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withZones (3352.37s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      3352.441s

[catriona-m]

Thanks for this @ziyeqf - this is looking pretty good so far, however it would be good if we could also include a test for primary_edge_zone and recovery_edge_zone just to confirm these work as expected too. Thanks!

[ziyeqf]

@catriona-m sure, test case added. Sorry for missing that one.

[catriona-m]

Thanks @ziyeqf - just spotted a couple of minor things on having a second look, but otherwise looking pretty good! Thanks!

[katbyte]

LGTM 📺

[github-actions]

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.