Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: managed applications: swap to hashicorp/go-azure-sdk #21571

Merged
merged 27 commits into from
Jul 7, 2023

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 27, 2023

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tombuildsstuff tombuildsstuff force-pushed the kt/managed-pandora-applications branch from f8c0f84 to dcb86b2 Compare April 27, 2023 11:45
@tombuildsstuff
Copy link
Contributor

Cherry-picked this commit atop of main

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @katbyte

Thanks for this PR - I've taken a look through and left some comments inline - I think it'd be worth being a little more consistent across resources here to make PR review easier, namely using model, props and payload as known variables, so that when reviewing PR's we don't need to repeatedly keep track of different variable names? It's minor but I think the consistency would be beneficial?

Thanks!

katbyte and others added 2 commits May 24, 2023 14:33
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
katbyte and others added 10 commits May 24, 2023 14:36
…urce_test.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource_test.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…urce.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title managed applications: swap to go-azure-sdk dependencies: managed applications: swap to hashicorp/go-azure-sdk Jul 7, 2023
@mbfrahry mbfrahry merged commit bd92261 into main Jul 7, 2023
@mbfrahry mbfrahry deleted the kt/managed-pandora-applications branch July 7, 2023 21:21
mbfrahry added a commit that referenced this pull request Jul 7, 2023
@github-actions github-actions bot added this to the v3.65.0 milestone Jul 7, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants