-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: managed applications: swap to hashicorp/go-azure-sdk
#21571
Conversation
f8c0f84
to
dcb86b2
Compare
Cherry-picked this commit atop of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @katbyte
Thanks for this PR - I've taken a look through and left some comments inline - I think it'd be worth being a little more consistent across resources here to make PR review easier, namely using model
, props
and payload
as known variables, so that when reviewing PR's we don't need to repeatedly keep track of different variable names? It's minor but I think the consistency would be beneficial?
Thanks!
internal/services/managedapplications/managed_application_definition_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_definition_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_definition_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…urce_test.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource_test.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…urce.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hashicorp/go-azure-sdk
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.