Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_firewall_policy_rule_collection_group - support ip range for addresses #21542

Merged
merged 1 commit into from
Apr 26, 2023
Merged

azurerm_firewall_policy_rule_collection_group - support ip range for addresses #21542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/services/firewall/firewall_policy_rule_collection_group_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ func resourceFirewallPolicyRuleCollectionGroup() *pluginsdk.Resource {
Type: pluginsdk.TypeString,
ValidateFunc: validation.Any(
validation.IsIPAddress,
validation.IsIPv4Range,
validation.IsCIDR,
validation.StringInSlice([]string{`*`}, false),
),
Expand All @@ -149,6 +150,7 @@ func resourceFirewallPolicyRuleCollectionGroup() *pluginsdk.Resource {
Type: pluginsdk.TypeString,
ValidateFunc: validation.Any(
validation.IsIPAddress,
validation.IsIPv4Range,
validation.IsCIDR,
validation.StringInSlice([]string{`*`}, false),
),
Expand Down Expand Up @@ -252,6 +254,7 @@ func resourceFirewallPolicyRuleCollectionGroup() *pluginsdk.Resource {
Type: pluginsdk.TypeString,
ValidateFunc: validation.Any(
validation.IsIPAddress,
validation.IsIPv4Range,
validation.IsCIDR,
validation.StringInSlice([]string{`*`}, false),
),
Expand Down Expand Up @@ -362,6 +365,7 @@ func resourceFirewallPolicyRuleCollectionGroup() *pluginsdk.Resource {
Type: pluginsdk.TypeString,
ValidateFunc: validation.Any(
validation.IsIPAddress,
validation.IsIPv4Range,
validation.IsCIDR,
validation.StringInSlice([]string{`*`}, false),
),
Expand Down
10 changes: 5 additions & 5 deletions website/docs/r/firewall_policy_rule_collection_group.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ A `application_rule` (application rule) block supports the following:

* `protocols` - (Optional) One or more `protocols` blocks as defined below. Not required when specifying `destination_fqdn_tags`, but required when specifying `destination_fqdns`.

* `source_addresses` - (Optional) Specifies a list of source IP addresses (including CIDR and `*`).
* `source_addresses` - (Optional) Specifies a list of source IP addresses (including CIDR, IP range and `*`).

* `source_ip_groups` - (Optional) Specifies a list of source IP groups.

* `destination_addresses` - (Optional) Specifies a list of destination IP addresses (including CIDR and `*`).
* `destination_addresses` - (Optional) Specifies a list of destination IP addresses (including CIDR, IP range and `*`).

* `destination_urls` - (Optional) Specifies a list of destination URLs for which policy should hold. Needs Premium SKU for Firewall Policy. Conflicts with `destination_fqdns`.

Expand All @@ -167,11 +167,11 @@ A `network_rule` (network rule) block supports the following:

* `destination_ports` - (Required) Specifies a list of destination ports.

* `source_addresses` - (Optional) Specifies a list of source IP addresses (including CIDR and `*`).
* `source_addresses` - (Optional) Specifies a list of source IP addresses (including CIDR, IP range and `*`).

* `source_ip_groups` - (Optional) Specifies a list of source IP groups.

* `destination_addresses` - (Optional) Specifies a list of destination IP addresses (including CIDR and `*`) or Service Tags.
* `destination_addresses` - (Optional) Specifies a list of destination IP addresses (including CIDR, IP range and `*`) or Service Tags.

* `destination_ip_groups` - (Optional) Specifies a list of destination IP groups.

Expand All @@ -185,7 +185,7 @@ A `nat_rule` (NAT rule) block supports the following:

* `protocols` - (Required) Specifies a list of network protocols this rule applies to. Possible values are `TCP`, `UDP`.

* `source_addresses` - (Optional) Specifies a list of source IP addresses (including CIDR and `*`).
* `source_addresses` - (Optional) Specifies a list of source IP addresses (including CIDR, IP range and `*`).

* `source_ip_groups` - (Optional) Specifies a list of source IP groups.

Expand Down