Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement:] azurerm_cosmosdb_account - update the default_identity_type error message for UserAssignedIdentity #21513

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Apr 24, 2023

The original error message for this filed was confusing and not helpful. I have added an example to the error message of the expected format of the input and also incorporated that into the documentation along with a sample configuration using the UserAssignedIdentity as the default_identity_type.

NOTE: Running the tests against this PR is not needed as it is only a text and documentation update, no code was actually touched in the resource.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💡

website/docs/r/cosmosdb_account.html.markdown Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_account_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 0ff61aa into main Apr 25, 2023
@katbyte katbyte deleted the e_cosmosdb_account_identity branch April 25, 2023 18:07
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants