Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_automation_software_update_configuration: fix panic issue #21311

Merged
merged 4 commits into from
Apr 11, 2023
Merged

azurerm_automation_software_update_configuration: fix panic issue #21311

merged 4 commits into from
Apr 11, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Apr 6, 2023

fixes: #21277

stephybun
stephybun requested changes Apr 6, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuxu92 could you add an acceptance test to verify this fix?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Apr 7, 2023

@wuxu92 could you add an acceptance test to verify this fix?

i have add a sinlge acc test with pre/post task configured, updated the document's example code too.

stephybun
stephybun approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 👍

@stephybun stephybun merged commit ad35a44 into hashicorp:main Apr 11, 2023
@github-actions github-actions bot added this to the v3.51.0 milestone Apr 11, 2023
@ASHR4 ASHR4 mentioned this pull request Apr 11, 2023
Closed
1 task
@jackofallops jackofallops modified the milestones: v3.51.0, v3.52.0 Apr 11, 2023
@wuxu92 wuxu92 deleted the fix/suppanic branch April 13, 2023 04:14
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug crash documentation service/automation size/M
Projects
None yet
Milestone
v3.52.0
Development

Successfully merging this pull request may close these issues.

azurerm_automation_software_update_configuration Plugin did not respond
3 participants
@wuxu92 @stephybun @jackofallops