azurerm_subscription - Fix error for subscription update

[ms-zhenhua]

fix #21241
Related PR: #18813

[tombuildsstuff]

hi @ms-zhenhua

Thanks for this PR.

As mentioned previously, we intentionally avoid hard-coding the Resource IDs in this fashion, we have the New{Type}ID methods which will return a ResourceID type, which has the .ID() method on it returning the expected string for this Resource ID.

As such can we update this to match the other resources in the Provider (and use the NewSubscriptionID method rather than hard-coding this)?

Thanks!

[ms-zhenhua]

Hi @tombuildsstuff, thank you for reviewing. I have updated the code. Kindly take another review.

[jackofallops]

Manual Testing results:

Create

azurerm_subscription.test: Still creating... [1m50s elapsed]
azurerm_subscription.test: Still creating... [2m0s elapsed]
azurerm_subscription.test: Creation complete after 2m10s [id=/providers/Microsoft.Subscription/aliases/testAcc-SteDev20230413-1]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Update

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # azurerm_subscription.test will be updated in-place
  ~ resource "azurerm_subscription" "test" {
        id                = "/providers/Microsoft.Subscription/aliases/testAcc-SteDev20230413-1"
      ~ tags              = {
          + "updated" = "true"
        }
        # (5 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
azurerm_subscription.test: Modifying... [id=/providers/Microsoft.Subscription/aliases/testAcc-SteDev20230413-1]
azurerm_subscription.test: Modifications complete after 3s [id=/providers/Microsoft.Subscription/aliases/testAcc-SteDev20230413-1]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

[jackofallops]

Thanks @ms-zhenhua - Tested successfully and LGTM 👍

[github-actions]

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!