Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding not_data_actions and data_actions to azurerm_role_definition datasource #2110

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 18, 2018

No description provided.

@katbyte katbyte added the bug label Oct 18, 2018
@katbyte katbyte added this to the 1.17.0 milestone Oct 18, 2018
@katbyte katbyte requested a review from a team October 18, 2018 05:17
@ghost ghost added the size/XS label Oct 18, 2018
katbyte added a commit that referenced this pull request Oct 18, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Oct 18, 2018

Tests pass:
screen shot 2018-10-17 at 22 24 41

@katbyte katbyte changed the title Added mising properties not_data_actions and data_actions to azurerm_role_definition datasource Adding not_data_actions and data_actions to azurerm_role_definition datasource Oct 18, 2018
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte merged commit 35b019c into master Oct 18, 2018
@katbyte katbyte deleted the b/ds-roledef-data-actions branch October 18, 2018 05:40
katbyte added a commit that referenced this pull request Oct 18, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants