Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_[linux|windows]_[function|web]_app[_slot] - fix AAD auth and token_store #21091

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

jackofallops
Copy link
Member

  • azurerm_linux_function_app - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_linux_function_app - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_linux_function_app_slot - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_linux_function_app_slot - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_linux_web_app - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_linux_web_app - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_linux_web_app_slot - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_linux_web_app_slot - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_windows_function_app - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_windows_function_app - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_windows_function_app_slot - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_windows_function_app_slot - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_windows_web_app - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_windows_web_app - fix read for token_store_enabled to correctly set returned value in state

  • azurerm_windows_web_app_slot - fix auth_v2 active_directory_v2 sending empty data

  • azurerm_windows_web_app_slot - fix read for token_store_enabled to correctly set returned value in state

closes #20913
closes #21021
closes #20820

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔏

@manicminer manicminer added this to the v3.49.0 milestone Mar 23, 2023
@jackofallops
Copy link
Member Author

Tests look fine - failures are transient/unrelated

image

@jackofallops jackofallops merged commit 01185e0 into main Mar 23, 2023
@jackofallops jackofallops deleted the b/authv2-aad-fixes branch March 23, 2023 18:03
jackofallops added a commit that referenced this pull request Mar 23, 2023
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.