azurerm_application_insights - re-add support for updating workspace_id
#21029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myc2h6o
force-pushed
the
app_insight_workspace
branch
from
33786d3 to
241bd1a
Compare
|
Test result |
|
This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #20968, the removal of the support for updating
workspace_idseems not user friendly since it can lose insights data while Azure supports updating it. And as said in this post that the Application Insights resource without aworkspace_idwould be deprecated on 2024 Feb. 29th, it looks like there would be lower possibility in the future that a user removes theworkspace_idof a current existing Application Insight resource, instead, the possibility of the update scenario would be more, so probably we should add the support for in-place update back for this resource.