Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: updating to v0.20230317.1100159 of github.com/hashicorp/go-azure-sdk #21004

Merged
merged 2 commits into from
Mar 17, 2023
Merged

dependencies: updating to v0.20230317.1100159 of github.com/hashicorp/go-azure-sdk #21004

merged 2 commits into from
Mar 17, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This includes updating the databricks package to use the new base layer from hashicorp/go-azure-sdk rather than Azure/go-autorest

* dependencies: updating to `v0.20230317.1100159` of `github.com/hashicorp/go-azure-sdk`
* `databricks`: refactoring to use `hashicorp/go-azure-sdk` as a base layer rather than `Azure/go-autorest`

@tombuildsstuff tombuildsstuff added this to the v3.49.0 milestone Mar 17, 2023
@tombuildsstuff tombuildsstuff marked this pull request as ready for review March 17, 2023 10:12
jackofallops
jackofallops approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Tests look fine (no regressions, but some test cases require updating in main)

@tombuildsstuff tombuildsstuff merged commit 0054e7b into main Mar 17, 2023
@tombuildsstuff tombuildsstuff deleted the f/dependencies-go-azure-sdk branch March 17, 2023 11:29
tombuildsstuff added a commit that referenced this pull request Mar 17, 2023
@tombuildsstuff
updating to include #21004
e6c0285
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 17, 2023
Merged
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
dependencies service/databricks size/XL
Projects
None yet
Milestone
v3.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @jackofallops