-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource : azurerm_storage_mover
#21000
New Resource : azurerm_storage_mover
#21000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sinbai, assuming the tests are good this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sinbai This service availability seems limited, please can you update the tests to use one of eastus, eastus2, westus3 or swedencentral instead of the default location?
@manicminer thanks for your feedback. The setting of Teamcity has been updated. Could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to register the RP?
Error: creating Storage Mover (Subscription: "*******"
Resource Group Name: "acctest-rg-230321013753853492"
Storage Mover Name: "acctest-ssm-230321013753853492"): unexpected status 409 with response: {"error":{"code":"MissingSubscriptionRegistration","message":"The subscription is not registered to use namespace 'Microsoft.StorageMover'. See https://aka.ms/rps-not-found for how to register subscriptions.","details":[{"code":"MissingSubscriptionRegistration","target":"Microsoft.StorageMover","message":"The subscription is not registered to use namespace 'Microsoft.StorageMover'. See https://aka.ms/rps-not-found for how to register subscriptions."}]}}
Yes. This is a new service. Could you please help to register |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add it to the list of RPs to register in the resourceproviders
package
c582345
to
493b31d
Compare
1ebe61f
to
d20ff92
Compare
@katbyte Thanks for letting me know this. I have added it. Could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sinbai - LGTM 🧮
This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Swagger Link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storagemover/resource-manager/Microsoft.StorageMover/stable/2023-03-01/storagemover.json
Test Results:
PASS: TestAccStorageMover_basic (355.79s)
PASS: TestAccStorageMover_requiresImport (384.30s)
PASS: TestAccStorageMover_complete (371.36s)
PASS: TestAccStorageMover_update (606.43s)