Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix missing use of oidc_token_file_path, CLI auth with Cloud Shell #20824

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

manicminer
Copy link
Contributor

  • provider: fix an issue with authentication using oidc_token_file_path
  • provider: fix an issue with Azure CLI authentication when running in Azure Cloud Shell

Closes: #20674
Closes: #20794

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments inline but 👍

.github/workflows/provider-test.yml Outdated Show resolved Hide resolved
.github/workflows/provider-test.yml Show resolved Hide resolved
@manicminer manicminer merged commit e48ec9a into main Mar 9, 2023
@manicminer manicminer deleted the bugfix/auth branch March 9, 2023 19:22
manicminer added a commit that referenced this pull request Mar 9, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants