Exposed ignore_missing_vnet_service_endpoint attribute #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +85,7 @@ The following arguments are supported: | |||
|
|
|||
| * `subnet_id` - (Required) The ID of the subnet that the PostgreSQL server will be connected to. | |||
|
|
|||
| ~> **NOTE:** Due to [a bug in the Azure API](https://github.com/Azure/azure-rest-api-specs/issues/3719) this resource currently doesn't expose the `ignore_missing_vnet_service_endpoint` field and defaults this to `false`. Terraform will check during the provisioning of the Virtual Network Rule that the Subnet contains the Service Rule to verify that the Virtual Network Rule can be created. | |||
| * `ignore_missing_vnet_service_endpoint` - (Optional) Create the virtual network rule before the subnet has the virtual network service endpoint enabled. The default value is false. | |||
There was a problem hiding this comment.
Create the virtual network rule before the subnet has the virtual network service endpoint enabled. The default value is false.
I think we could phrase this better to match the syntax of the other fields:
Should the Virtual Network Rule be created before the Subnet has the Virtual Network Service Endpoint enabled? Defaults to `false`
There was a problem hiding this comment.
How about I copy it from the API docs directly?
Create firewall rule before the virtual network has vnet service endpoint enabled.
There was a problem hiding this comment.
Sure - but we should still match the language used across the other resources, which prefixes things with Should [xxx] be applied/enabled etc?
JunyiYi
reviewed
Oct 11, 2018
|
|
tombuildsstuff
added a commit
that referenced
this pull request
Oct 12, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue for the ignore_missing_vnet_service_endpoint attribute, turns out it's an async operation for Postgre SQL. Currently have many customers asking for this functionality.