azurerm_mariadb_server: Add support for ssl_minimal_tls_version_enforced
#20556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forced` ``` $ TF_ACC=1 go test -v ./internal/services/mariadb -timeout=1000m -run='TestAccMariaDbServer_basicTenTwo' === RUN TestAccMariaDbServer_basicTenTwo === PAUSE TestAccMariaDbServer_basicTenTwo === CONT TestAccMariaDbServer_basicTenTwo --- PASS: TestAccMariaDbServer_basicTenTwo (296.33s) PASS ok github.com/hashicorp/terraform-provider-azurerm/internal/services/mariadb 297.574s ``` Fixes hashicorp#7899
github-actions
bot
added
service/data-factory
service/data-share
size/L
and removed
size/S
labels
|
|
favoretti
changed the title
azurerm_mariadb_server: Add support for `ssl_minimal_tls_version_en…azurerm_mariadb_server: Add support for ssl_minimal_tls_version_enforced
stephybun
requested changes
Feb 21, 2023
There was a problem hiding this comment.
Thanks for this @favoretti, one minor typo in the docs and also a concern regarding the default value for the property. Once those are resolved this should be good to go though!
| @@ -76,6 +77,8 @@ The following arguments are supported: | |||
|
|
|||
| * `ssl_enforcement_enabled` - (Required) Specifies if SSL should be enforced on connections. Possible values are `true` and `false`. | |||
|
|
|||
| * `ssl_minimal_tls_version_enforced` - (Optional) The minimum TLS version to support on the sever. Possible values are `TLSEnforcementDisabled`, `TLS1_0`, `TLS1_1`, and `TLS1_2`. Defaults to `TLS1_2`. | |||
There was a problem hiding this comment.
Suggested change
| * `ssl_minimal_tls_version_enforced` - (Optional) The minimum TLS version to support on the sever. Possible values are `TLSEnforcementDisabled`, `TLS1_0`, `TLS1_1`, and `TLS1_2`. Defaults to `TLS1_2`. | |
| * `ssl_minimal_tls_version_enforced` - (Optional) The minimum TLS version to support on the server. Possible values are `TLSEnforcementDisabled`, `TLS1_0`, `TLS1_1`, and `TLS1_2`. Defaults to `TLS1_2`. |
Comment on lines
+153
to
+158
| "ssl_minimal_tls_version_enforced": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Default: string(servers.MinimalTlsVersionEnumTLSOneTwo), | ||
| ValidateFunc: validation.StringInSlice(servers.PossibleValuesForMinimalTlsVersionEnum(), false), | ||
| }, |
There was a problem hiding this comment.
Whilst I agree from a security perspective that this should be defaulted to TLS1_2, it looks like the API is defaulting this to TLSEnforcementDisabled. Perhaps this should be Computed for now and default to TLS1_2 in 4.x?
|
@favoretti any updates? |
|
Oh, I’m so sorry, I totally forgot about this one. Will pick it up later
today.
…On Tue, 4 Apr 2023 at 12:11, stephybun ***@***.***> wrote:
@favoretti <https://github.com/favoretti> any updates?
—
Reply to this email directly, view it on GitHub
<#20556 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGERNUCVYALWN5HDAYTL43W7PXT5ANCNFSM6AAAAAAVBBFWDE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah, it seems #20782 got merged ahead of slowpokle me :) Closing this one then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7899