azurerm_mobile_network_sim_group - update schema

[ziyeqf]

update per #20339 (comment)

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkSimGroup -timeout=600m
=== RUN   TestAccMobileNetworkSimGroupDataSource_complete
=== PAUSE TestAccMobileNetworkSimGroupDataSource_complete
=== RUN   TestAccMobileNetworkSimGroup_basic
=== PAUSE TestAccMobileNetworkSimGroup_basic
=== RUN   TestAccMobileNetworkSimGroup_withEncryptionKeyUrl
=== PAUSE TestAccMobileNetworkSimGroup_withEncryptionKeyUrl
=== RUN   TestAccMobileNetworkSimGroup_requiresImport
=== PAUSE TestAccMobileNetworkSimGroup_requiresImport
=== RUN   TestAccMobileNetworkSimGroup_complete
=== PAUSE TestAccMobileNetworkSimGroup_complete
=== RUN   TestAccMobileNetworkSimGroup_update
=== PAUSE TestAccMobileNetworkSimGroup_update
=== CONT  TestAccMobileNetworkSimGroupDataSource_complete
=== CONT  TestAccMobileNetworkSimGroup_requiresImport
=== CONT  TestAccMobileNetworkSimGroup_update
=== CONT  TestAccMobileNetworkSimGroup_complete
=== CONT  TestAccMobileNetworkSimGroup_withEncryptionKeyUrl
=== CONT  TestAccMobileNetworkSimGroup_basic
--- PASS: TestAccMobileNetworkSimGroup_basic (467.71s)
--- PASS: TestAccMobileNetworkSimGroup_requiresImport (491.87s)
--- PASS: TestAccMobileNetworkSimGroup_withEncryptionKeyUrl (760.82s)
--- PASS: TestAccMobileNetworkSimGroupDataSource_complete (781.69s)
--- PASS: TestAccMobileNetworkSimGroup_complete (782.60s)
--- PASS: TestAccMobileNetworkSimGroup_update (940.80s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 942.042s

[tombuildsstuff]

we also need to update the Expand and Flatten functions to account for this?

[ziyeqf]

the typed model is correct so I think these functions are ok?

[tombuildsstuff]

so if the service were to support system assigned, the provider would crash due to the flattened schema not matching what's defined in the schema - we'll need to ensure these are all using the user assigned values here

[ziyeqf]

I dont think it will crash? with the flatten code accept both SystemAssigned and UserAssigned but only use the UserAssgined one .

func flattenMobileNetworkUserAssignedToNetworkLegacyIdentity(input *identity.LegacySystemAndUserAssignedMap) ([]identity.ModelUserAssigned, error) {
	if input == nil {
		return nil, nil
	}
	tmp := identity.UserAssignedMap{
		Type:        input.Type,
		IdentityIds: input.IdentityIds,
	}
	output, err := identity.FlattenUserAssignedMapToModel(&tmp)
	if err != nil {
		return nil, fmt.Errorf("expanding `identity`: %+v", err)
	}
	return *output, nil
}

[stephybun]

Thanks @ziyeqf LGTM 🍐

[github-actions]

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.