azurerm_windows_web_app,azurerm_windows_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_web_app,azurerm_linux_web_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot - add hosting_environment_id property
#20471
Conversation
There was a problem hiding this comment.
Hi @xiaxyi - Thanks for this PR. I've left a few comments inline below if you can take a look and address I think this will be good to merge.
Thanks!
| @@ -639,6 +645,10 @@ func (r WindowsFunctionAppResource) Read() sdk.ResourceFunc { | |||
| DefaultHostname: utils.NormalizeNilableString(props.DefaultHostName), | |||
| } | |||
|
|
|||
| if hostingEnv := props.HostingEnvironmentProfile; hostingEnv != nil { | |||
| state.HostingEnvId = utils.NormalizeNilableString(hostingEnv.ID) | |||
There was a problem hiding this comment.
Can we change this to use the pointer package as it's already imported? We'll be refactoring all references of this soon, but we shouldn't continue use of the utils package in new changes.
| @@ -314,6 +320,9 @@ func (d WindowsWebAppDataSource) Read() sdk.ResourceFunc { | |||
| if subnetId := utils.NormalizeNilableString(props.VirtualNetworkSubnetID); subnetId != "" { | |||
| webApp.VirtualNetworkSubnetID = subnetId | |||
| } | |||
| if hostingEnv := props.HostingEnvironmentProfile; hostingEnv != nil { | |||
| webApp.HostingEnvId = utils.NormalizeNilableString(hostingEnv.ID) | |||
There was a problem hiding this comment.
As above, can we change to pointer package here?
| @@ -63,6 +63,8 @@ In addition to the Arguments listed above - the following Attributes are exporte | |||
|
|
|||
| * `default_hostname` - The default hostname of the Linux Function App. | |||
|
|
|||
| * `hosting_environment_id` - The hosting environment id used by Function App. | |||
There was a problem hiding this comment.
The resource name in the provider is app_servce_environment we should make this clearer in the documentation references? Perhaps:
| * `hosting_environment_id` - The hosting environment id used by Function App. | |
| * `hosting_environment_id` - The ID of the App Service Environment used by this Linux Function App. |
Can you also do similar for the other property references below?
|
Thanks @jackofallops , code is updated. |
|
This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.