Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_data_connector_threat_intelligence_taxii - Fix date format for lookback_date #20229

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jan 31, 2023

Fix the issue reported at #19209 (comment). The issue is due to a change introduced at service side, which cause the date format changed. That service side change has now been reverted. But due to the original PR #19209 is implemented during the time when that change is in effect, we now need to modify the date format in this PR to align with current behavior of the service, which is not going to change until Azure/azure-rest-api-specs#21487 is resolved.

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/sentinel -run=TestAccDataConnectorThreatIntelligenceTAXII_complete
=== RUN   TestAccDataConnectorThreatIntelligenceTAXII_complete
=== PAUSE TestAccDataConnectorThreatIntelligenceTAXII_complete
=== CONT  TestAccDataConnectorThreatIntelligenceTAXII_complete
--- PASS: TestAccDataConnectorThreatIntelligenceTAXII_complete (213.57s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      213.584s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏳

@katbyte katbyte merged commit 03ab43a into hashicorp:main Feb 6, 2023
@github-actions github-actions bot added this to the v3.43.0 milestone Feb 6, 2023
@github-actions
Copy link

This functionality has been released in v3.43.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants