Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_builtin_role_definition: support for data_actions and not_data_actions #2000

Merged
merged 3 commits into from
Oct 1, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Noticed this was failing due to a bad set - this PR exposes the data_actions and not_data_actions fields on the azurerm_builtin_role_definition data source. This also fixes some broken tests in the AzureAD Application Data Source, where https is now required

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMBuiltInRoleDefinition
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_contributor
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_contributor (43.84s)
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_owner
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_owner (49.15s)
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_reader
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_reader (41.09s)
=== RUN   TestAccDataSourceAzureRMBuiltInRoleDefinition_virtualMachineContributor
--- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_virtualMachineContributor (46.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	181.693s
$ acctests azurerm  TestAccDataSourceAzureRMAzureADApplication_
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byObjectId
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectId (101.60s)
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete (86.52s)
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byName
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byName (94.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	282.602s

Copy link
Contributor Author

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed a couple of minor potential crash points during a re-review

@tombuildsstuff tombuildsstuff requested a review from katbyte October 1, 2018 02:27
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-10-01 at 19 28 02

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats to 2000th PR 🎊 😄

@tombuildsstuff tombuildsstuff merged commit b849d4d into master Oct 1, 2018
@tombuildsstuff tombuildsstuff deleted the broken-tests branch October 1, 2018 06:37
tombuildsstuff added a commit that referenced this pull request Oct 1, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants