azurerm_mssql_database - threat_detection_policy.0.storage_* can now be correctly set as empty
#19670
Conversation
mbfrahry
commented
Dec 14, 2022
•
mbfrahry
commented
… detection policies
| @@ -742,10 +742,10 @@ func expandMsSqlServerSecurityAlertPolicy(d *pluginsdk.ResourceData) sql.Databas | |||
| if v, ok := securityAlert["retention_days"]; ok { | |||
| properties.RetentionDays = utils.Int32(int32(v.(int))) | |||
| } | |||
| if v, ok := securityAlert["storage_account_access_key"]; ok { | |||
| if v, ok := securityAlert["storage_account_access_key"]; ok && v.(string) != "" { | |||
There was a problem hiding this comment.
I think doing this means these can no longer be removed, can we add a test removing these to confirm that works?
There was a problem hiding this comment.
It was all good with no code changes but I added a test to confirm!
| properties.StorageAccountAccessKey = utils.String(v.(string)) | ||
| } | ||
| if v, ok := securityAlert["storage_endpoint"]; ok { | ||
| if v, ok := securityAlert["storage_endpoint"]; ok && v.(string) != "" { |
There was a problem hiding this comment.
I think doing this means these can no longer be removed, can we add a test removing these to confirm that works?
|
This functionality has been released in v3.36.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
…now be correctly set as empty (hashicorp#19670)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
