Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource: azurerm_spring_cloud_accelerator #19572

Merged
merged 2 commits into from
Dec 12, 2022
Merged

new resource: azurerm_spring_cloud_accelerator #19572

merged 2 commits into from
Dec 12, 2022

Conversation

ms-henglu
Copy link
Contributor 

=== RUN   TestAccSpringCloudAccelerator_basic
=== PAUSE TestAccSpringCloudAccelerator_basic
=== CONT  TestAccSpringCloudAccelerator_basic
=== RUN   TestAccSpringCloudAccelerator_requiresImport
=== PAUSE TestAccSpringCloudAccelerator_requiresImport
=== CONT  TestAccSpringCloudAccelerator_requiresImport
--- PASS: TestAccSpringCloudAccelerator_basic (1458.61s)
--- PASS: TestAccSpringCloudAccelerator_requiresImport (1843.63s)
PASS

@ms-henglu ms-henglu force-pushed the ticket-16370646-spring-cloud-accelerator branch from 8276ce0 to 29f9401 Compare December 6, 2022 06:13
katbyte
katbyte requested changes Dec 7, 2022
View reviewed changes
website/docs/r/spring_cloud_accelerator.html.markdown
Comment on lines +40 to +48
## Arguments Reference

The following arguments are supported:

* `name` - (Required) The name which should be used for this Spring Cloud Accelerator. Changing this forces a new Spring Cloud Accelerator to be created. The only possible value is `default`.

* `spring_cloud_service_id` - (Required) The ID of the Spring Cloud Service. Changing this forces a new Spring Cloud Accelerator to be created.

## Attributes Reference
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this resource do exactly? should there be more properties?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a parent resource of customized accelerator resources.

katbyte
katbyte approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍔

@katbyte katbyte merged commit 18ddf07 into hashicorp:main Dec 12, 2022
katbyte added a commit that referenced this pull request Dec 12, 2022
@katbyte
CHANGELOG #19572
ab15afc
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@ms-henglu @favoretti
new resource: azurerm_spring_cloud_accelerator (hashicorp#19572)
fdefa09
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@katbyte @favoretti
CHANGELOG hashicorp#19572
bf2ae22
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/spring size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-henglu @katbyte