Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run format on the code #1957

Closed
wants to merge 1 commit into from
Closed

Conversation

wilsonge
Copy link

Currently you can't run make build on the repo because the code style checks fail. This runs make fmt on the code so that you can run make build again

@ghost ghost added the size/M label Sep 20, 2018
@tombuildsstuff
Copy link
Contributor

hey @wilsonge

Thanks for this PR :)

The go fmt changes required in this PR are coming from changes to the formatter in Go 1.11. As we're currently using Go 1.10 - we're planning on updating to Go 1.11 once #1746 has been merged (since that involves a large number of changes, we're trying to avoid conflicts). Since this is currently intentional - I'm going to close this PR for the moment, but you should be able to use goenv to work with multiple versions of Go for the moment.

Thanks!

@wilsonge wilsonge deleted the fix/format branch September 21, 2018 11:18
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants