azurerm_storage_account - adds support for enabling SFTP

[leesutcliffe]

This PR is to add SFTP support to the azurerm_storage_account resource.
A sftp_enabled property has been added which takes a boolean value to enable or disable the service

Relates-to: #14736

Acceptance tests run successfully

make acctests SERVICE=storage TESTARGS='-run=TestAccStorageAccount_isSftpEnabled' TESTTIMEOUT='60m'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/storage -run=TestAccStorageAccount_isSftpEnabled -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStorageAccount_isSftpEnabled
=== PAUSE TestAccStorageAccount_isSftpEnabled
=== CONT  TestAccStorageAccount_isSftpEnabled
--- PASS: TestAccStorageAccount_isSftpEnabled (190.48s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       (cached)

The locally complied provider works as expected

Terraform will perform the following actions:
<...OUTPUT OMITTED...>
  # azurerm_storage_account.this will be created
  + resource "azurerm_storage_account" "this" {
      + access_tier                       = (known after apply)
      + account_kind                      = "StorageV2"
      + account_replication_type          = "LRS"
      + account_tier                      = "Standard"
     <...OUTPUT OMITTED...>
      + sftp_enabled                      = true

      <...OUTPUT OMITTED...>

[jackofallops]

Hi @leesutcliffe
Thanks for the PR. The change looks good, but the linters are failing. Could you take a look at the action failures and we'll re-review when the failures are addressed? (I think it might just be make fmt required)

Thanks!

[leesutcliffe]

Thanks @jackofallops lint errors resolved

[tombuildsstuff]

hey @leesutcliffe

Thanks for pushing those changes, I've taken a look through and left a couple of minor comments inline but this otherwise LGTM 👍

[stephybun]

Thanks for this @leesutcliffe LGTM 🥭

[github-actions]

This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.