allow up-to-two client certs

[steve-hawkins]

This should address #1938

[katbyte]

Hi @steve-hawkins,

This LGTM, however could we get an acceptance test to verify this works?

[steve-hawkins]

@katbyte thanks for the feedback, think that test should cover it

apologies for my ignorance here, but how would I run a targeted acceptance test?

the contributor guide suggests make testacc which will run the full set of acceptance tests, this worries me from an actually creating things in Azure / cost perspective

[katbyte]

@steve-hawkins,

You can run just one test with this command:

make fmt; make testacc TEST=./azurestack TESTARGS=-test.run=TestAccAzureStackStorageAccount_basic

or all tests starting with a pattern with this command:

make fmt; make testacc TEST=./azurestack TESTARGS=-test.run=TestAccAzureStackStorageAccount

[katbyte]

@steve-hawkins,

Thanks for adding the test so quickly! I forgot to mention the docs should be updated. I hope you don't mind but I pushed a change for that myself to get this merged today.

[katbyte]

Tests pass:

[steve-hawkins]

thanks @katbyte for getting back so quickly

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!