Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_sentinel_data_connector_microsoft_threat_protection #19162

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Nov 7, 2022

Support new data connector: azurerm_sentinel_data_connector_microsoft_threat_protection. This corresponds to the Microsoft 365 Defender on Portal. For a fresh new tenant, you are not allowed to create this data connector. You'll need to do followings:

  1. Follow the official prerequisite: https://learn.microsoft.com/en-us/azure/sentinel/connect-microsoft-365-defender?tabs=MDE#prerequisites
  2. In the M365 Defender Portal (https://security.microsoft.com/) enable the integration button in Incidents page
  3. Wait some time (probably takes days...)

Then you'll be able to create the data connector via either user account or SP.

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/sentinel -run=TestAccSentinelDataConnectorMicrosoftThreatProtection_
=== RUN   TestAccSentinelDataConnectorMicrosoftThreatProtection_basic
=== PAUSE TestAccSentinelDataConnectorMicrosoftThreatProtection_basic
=== RUN   TestAccSentinelDataConnectorMicrosoftThreatProtection_complete
=== PAUSE TestAccSentinelDataConnectorMicrosoftThreatProtection_complete
=== RUN   TestAccSentinelDataConnectorMicrosoftThreatProtection_requiresImport
=== PAUSE TestAccSentinelDataConnectorMicrosoftThreatProtection_requiresImport
=== CONT  TestAccSentinelDataConnectorMicrosoftThreatProtection_basic
=== CONT  TestAccSentinelDataConnectorMicrosoftThreatProtection_requiresImport
=== CONT  TestAccSentinelDataConnectorMicrosoftThreatProtection_complete
--- PASS: TestAccSentinelDataConnectorMicrosoftThreatProtection_basic (77.13s)
--- PASS: TestAccSentinelDataConnectorMicrosoftThreatProtection_complete (139.38s)
--- PASS: TestAccSentinelDataConnectorMicrosoftThreatProtection_requiresImport (145.86s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      145.873s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔌

@katbyte katbyte merged commit 962050a into hashicorp:main Dec 9, 2022
katbyte added a commit that referenced this pull request Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants