Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_virtual_machine - support sql_instance_setting #19123

Merged
merged 2 commits into from
Nov 6, 2022
Merged

azurerm_mssql_virtual_machine - support sql_instance_setting #19123

merged 2 commits into from
Nov 6, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Nov 3, 2022

Fix #15824

@myc2h6o myc2h6o mentioned this pull request Nov 3, 2022
Closed
@myc2h6o
Copy link
Contributor Author

myc2h6o commented Nov 3, 2022

Test result
image

katbyte
katbyte requested changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment to address and then this looks good

internal/services/mssql/mssql_virtual_machine_resource.go Outdated
@@ -315,6 +315,64 @@ func resourceMsSqlVirtualMachine() *pluginsdk.Resource {
ValidateFunc: validate.SqlVirtualMachineLoginUserName,
},

"sql_instance_setting": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting seems redundant?

Suggested change
"sql_instance_setting": {
"sql_instance": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed _setting.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Nov 4, 2022

Hi @katbyte thanks for reviewing the pr! I've updated the code according to the comment. Please take a look

katbyte
katbyte approved these changes Nov 6, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @myc2h6o - LGTM 🦀

@katbyte katbyte merged commit a42d5d1 into hashicorp:main Nov 6, 2022
katbyte added a commit that referenced this pull request Nov 6, 2022
@katbyte
CHANGELOG #19123
0d99605
@github-actions github-actions bot added this to the v3.31.0 milestone Nov 6, 2022
@myc2h6o myc2h6o deleted the sql_instance branch November 7, 2022 00:51
@github-actions
Copy link

This functionality has been released in v3.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/mssql Microsoft SQL Server size/XL
Projects
None yet
Milestone
v3.31.0
Development

Successfully merging this pull request may close these issues.

Support for instance settings on azurerm_mssql_virtual_machine
2 participants
@myc2h6o @katbyte