-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_kubernetes_fleet_manager
#19111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments inline to fix in the next regeneration but this otherwise seems fine
}, | ||
ForceNew: true, | ||
MaxItems: 1, | ||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be marked as required
### `hub_profile` Block | ||
|
||
The `hub_profile` block supports the following arguments: | ||
|
||
* `dns_prefix` - (Required) | ||
|
||
The `hub_profile` block exports the following arguments: | ||
|
||
* `fqdn` - | ||
|
||
* `kubernetes_version` - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need mapping through
return []string{} | ||
func (autoRegistration) WebsiteCategories() []string { | ||
return []string{ | ||
"Kubernetes Fleet Manager", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be Containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ☂️
azurerm_kubernetes_fleet_manager
This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Regenerating the Terraform Provider based on the latest changes