Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kubernetes_fleet_manager #19111

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

hc-github-team-tf-azure
Copy link
Collaborator

Regenerating the Terraform Provider based on the latest changes

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline to fix in the next regeneration but this otherwise seems fine

},
ForceNew: true,
MaxItems: 1,
Optional: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be marked as required

Comment on lines +54 to +64
### `hub_profile` Block

The `hub_profile` block supports the following arguments:

* `dns_prefix` - (Required)

The `hub_profile` block exports the following arguments:

* `fqdn` -

* `kubernetes_version` -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need mapping through

return []string{}
func (autoRegistration) WebsiteCategories() []string {
return []string{
"Kubernetes Fleet Manager",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be Containers

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☂️

@tombuildsstuff tombuildsstuff changed the title Auto PR: Regenerating based on (479c94b39d3183923cd2bd3f0283243bc72a7cb1) New Resource: azurerm_kubernetes_fleet_manager Nov 2, 2022
@katbyte katbyte merged commit 76018c1 into main Nov 2, 2022
@katbyte katbyte deleted the auto-pr/55c6e1c5 branch November 2, 2022 18:39
tombuildsstuff added a commit that referenced this pull request Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants