-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug:] azurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override
rule
action
for DRS 2.0
#19095
Conversation
azurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override rule actionazurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override rule action for DRS 2.0 and above
azurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override rule action for DRS 2.0 and aboveazurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override
for DRS 2.0
azurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override
for DRS 2.0azurerm_cdn_frontdoor_firewall_policy
- expose AnomalyScoring
in override
rule
action
for DRS 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 comment 🚪
@@ -417,6 +418,7 @@ func resourceCdnFrontDoorFirewallPolicy() *pluginsdk.Resource { | |||
string(frontdoor.ActionTypeLog), | |||
string(frontdoor.ActionTypeBlock), | |||
string(frontdoor.ActionTypeRedirect), | |||
"AnomalyScoring", // Only valid with 2.0 and above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure this exists in swagger & if not open an issue to ensure it is added in future SDKs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened issue
This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This issue is due to the fact that the API defers the valid
version
/action
of theoverride
by thetype
value (e.g.DefaultRuleSet
orMicrosoft_DefaultRuleSet
). In version1.0
andpreview-0.1
(typeDefaultRuleSet
) the accepted actions are Allow, Block, Log, and Redirect, however in2.0
(typeMicrosoft_DefaultRuleSet
) the only valid action isAnomalyScoring
due to the DRS 2.0 implementing theOWASP
anomaly score model.Example of a DRS 1.X Override:
Example of a DRS 2.0 Override:
(fixes #18480)
(fixes #19088)