Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - support for the import property. #18588

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Sep 30, 2022

Test

TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlDatabase_bacpac -timeout=600m       
=== RUN   TestAccMsSqlDatabase_bacpac
=== PAUSE TestAccMsSqlDatabase_bacpac
=== CONT  TestAccMsSqlDatabase_bacpac
--- PASS: TestAccMsSqlDatabase_bacpac (1187.63s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 1188.778s

@github-actions github-actions bot added documentation service/mssql Microsoft SQL Server labels Sep 30, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thou i do have 1 final idea: as create mode defaults to default which is what you need for importing we could just make it conflict with import so the user can't actually set it to something other than default? then we don't have to document it/check on create and get plan time validation? 🤔 WDYT?

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Oct 13, 2022

LGTM, thou i do have 1 final idea: as create mode defaults to default which is what you need for importing we could just make it conflict with import so the user can't actually set it to something other than default? then we don't have to document it/check on create and get plan time validation? 🤔 WDYT?

Thank you for the idea, it does make sense. I have refactored the code. :)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @ziyeqf LGTM ☁️

@katbyte katbyte merged commit eca05e8 into hashicorp:main Oct 13, 2022
katbyte added a commit that referenced this pull request Oct 13, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 13, 2022
@github-actions
Copy link

This functionality has been released in v3.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ziyeqf ziyeqf deleted the tengzh/icm/add_mssql_import branch October 14, 2022 02:19
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants