Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_disk_encryption_set - identity support for UserAssigned and SystemUserAssgined identity #18525

Merged

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Sep 26, 2022

This PR is ready to review, while not able to merge before the feature become GA.
will be global avaiable by mid-October

Ref Link

TestAccDiskEncryptionSet_userAssignedIdentity

TF_ACC=1 go test -v ./internal/services/compute -run=TestAccDiskEncryptionSet_userAssignedIdentity -timeout=60m
=== RUN   TestAccDiskEncryptionSet_userAssignedIdentity
=== PAUSE TestAccDiskEncryptionSet_userAssignedIdentity
=== CONT  TestAccDiskEncryptionSet_userAssignedIdentity
--- PASS: TestAccDiskEncryptionSet_userAssignedIdentity (544.52s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       545.664s

TestAccDiskEncryptionSet_systemAssignedUserAssignedIdentity

TF_ACC=1 go test -v ./internal/services/compute -run=TestAccDiskEncryptionSet_systemAssignedUserAssignedIdentity -timeout=60m
=== RUN   TestAccDiskEncryptionSet_systemAssignedUserAssignedIdentity
=== PAUSE TestAccDiskEncryptionSet_systemAssignedUserAssignedIdentity
=== CONT  TestAccDiskEncryptionSet_systemAssignedUserAssignedIdentity
--- PASS: TestAccDiskEncryptionSet_systemAssignedUserAssignedIdentity (468.53s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       469.807s

@ziyeqf ziyeqf force-pushed the tengzh/add_diskencryptionsets_indentity_tmp branch from 27ea826 to 9c9a86e Compare September 26, 2022 04:44
@katbyte
Copy link
Collaborator

katbyte commented Oct 26, 2022

@ziyeqf - is the feature GA and this PR ready to go?

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Oct 27, 2022

@katbyte The feature will be avaiable in all regions in days, but will still need a manual step (azcli/powershell command) to enable for more days.
So I added a note in the doc. And then, I think it's ready to go.

@ziyeqf ziyeqf marked this pull request as ready for review October 27, 2022 02:29
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@katbyte katbyte closed this Oct 28, 2022
@katbyte katbyte reopened this Oct 28, 2022
@katbyte katbyte merged commit 2a79fca into hashicorp:main Oct 28, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 28, 2022
katbyte added a commit that referenced this pull request Oct 28, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ziyeqf ziyeqf deleted the tengzh/add_diskencryptionsets_indentity_tmp branch October 31, 2022 02:34
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants