Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_orchestrated_virtual_machine_scale_set - support for the user_data_base64 property #18486

Merged
merged 6 commits into from
Sep 24, 2022

Conversation

gcampbell12
Copy link
Contributor

@gcampbell12 gcampbell12 commented Sep 21, 2022

Adds user data to VMSS azurerm_orchestrated_virtual_machine_scale_set resource, the VMSS API requires this value to be base64 encoded hence the schema validation

@gcampbell12 gcampbell12 changed the title Add user_data to orchestrated VMSS Add user_data field to azurerm_orchestrated_virtual_machine_scale_set Sep 21, 2022
@gcampbell12 gcampbell12 changed the title Add user_data field to azurerm_orchestrated_virtual_machine_scale_set Add user_data property to azurerm_orchestrated_virtual_machine_scale_set Sep 21, 2022
@gcampbell12 gcampbell12 changed the title Add user_data property to azurerm_orchestrated_virtual_machine_scale_set azurerm_orchestrated_virtual_machine_scale_set - support for the user_data property Sep 21, 2022
@gcampbell12
Copy link
Contributor Author

Acceptance test results:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/compute -run=TestAccOrchestratedVirtualMachineScaleSet_otherUserData -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccOrchestratedVirtualMachineScaleSet_otherUserData
=== PAUSE TestAccOrchestratedVirtualMachineScaleSet_otherUserData
=== CONT  TestAccOrchestratedVirtualMachineScaleSet_otherUserData
--- PASS: TestAccOrchestratedVirtualMachineScaleSet_otherUserData (460.98s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       462.354s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gcampbell12, this LGTM thou i wonder if we should be explicit in what the property expects and call it user_data_base64 as we often put json etc on the end to make it clear

@gcampbell12 gcampbell12 changed the title azurerm_orchestrated_virtual_machine_scale_set - support for the user_data property azurerm_orchestrated_virtual_machine_scale_set - support for the user_data_base64 property Sep 22, 2022
@gcampbell12 gcampbell12 requested a review from katbyte September 22, 2022 18:43
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gcampbell12 - LGTM now ⚙️

@katbyte katbyte merged commit 4dfc7dd into hashicorp:main Sep 24, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 24, 2022
katbyte added a commit that referenced this pull request Sep 24, 2022
@github-actions
Copy link

This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants