Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - license_type is now also Computed #18230

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Sep 2, 2022

Some tests of resource azurerm_mssql_database failed with "After applying this test step, the plan was not empty."

The tests fail because in some cases the property LicenseType is set to default value LicenseIncluded. Checking the current API behavior as follows:

  1. When the value of createMode is set to Default and the value of LicenseType is not set, the API returns the value of LicenseType as LicenseIncluded.

  2. When the value of createMode is set to Copy, the value of LicenseType is not set and the LicenseType of the source database is set to BasePrice, the API returns the value of LicenseType as BasePrice.

  3. When the value of createMode is set to Copy, the value of LicenseType is set to LicenseIncluded and the LicenseType of the source database is set to BasePrice , the API returns the value of LicenseType as LicenseIncluded.

Per the above API behavior, I submitted this PR to add Computed = true for property license_type to fix the tests failure.

@github-actions github-actions bot added the service/mssql Microsoft SQL Server label Sep 2, 2022
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbfrahry mbfrahry changed the title azurerm_mssql_database - Fix acctests failure azurerm_mssql_database - license_type is now also Computed Sep 2, 2022
@mbfrahry mbfrahry modified the milestones: v3.21.1, v3.22.0 Sep 2, 2022
@mbfrahry mbfrahry merged commit 75040c1 into hashicorp:main Sep 2, 2022
mbfrahry added a commit that referenced this pull request Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v3.22.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants